magento / magento/catalog-storefront
Unify price event provider event data formation.
Open
@RakeshJesadiya is already working on this.
Since Dec 21, 2020.
Price Books
Progress: backlog
- Dominant language
- PHP
- Stars
- 7
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
The price event data providers contain some duplicate code. Specifically buildEventData functions in FullReindex and PartialReindex providers.
For example
\Magento\CatalogPriceDataExporter\Model\Provider\FullReindex\CustomOptionPriceEvent::buildEventData
and
\Magento\CatalogPriceDataExporter\Model\Provider\PartialReindex\CustomOptionPriceEvent::buildEventData
are the same.
We need to bring this logic out of the providers in order to avoid code duplication.
Related to https://github.com/magento/catalog-storefront/issues/465
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.