magento / magento/catalog-storefront

[TEST] Automate log-exception check mechanism for storefront integration tests

Open
#280 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Progress: in grooming Test
Dominant language
PHP
Stars
7
Forks
16
PR merge metrics
No merged PRs in 30d

Description

We do have manual check of exception log as one the Code Review steps.
We can automate it to accelerate the Review phase.

We Could create the NoExcept abstract class for tests and inherit it for all of the tests that shouldn't throw any exception. As part of the functionality of this parent class would be the substitution of LogInterface instance and verification the corresponding log file on the existence of exception after the test completed (TearDown phase).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the storefront integration tests and reviewing the current manual exception-log check used during code review. Define how the NoExcept abstract test class, LogInterface substitution, and teardown verification should apply to tests that must not throw exceptions; done means those tests automatically detect the corresponding exception log without manual review.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.