magento / magento/catalog-storefront

Handle missed GQL fields: price_range

Open
#249 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Progress: ready for grooming
Dominant language
PHP
Stars
7
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Overridden by "Deprecated resolver" fields should be covered by Storefront API. And depreciation logic should be removed
Field:
`price_range`

GQL scheme:
```
interface ProductInterface @typeResolver(class: "Magento\\CatalogGraphQl\\Model\\ProductInterfaceTypeResolverComposite") @doc(description: "The ProductInterface contains attributes that are common to all types of products. Note that descriptions may not be available for custom and EAV attributes.") {
price_range: PriceRange! @doc(description: "A PriceRange object, indicating the range of prices for the product") @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\PriceRange")
}
```

Overridden in:
app/code/Magento/CatalogStorefrontGraphQl/etc/di.xml
`
`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ProductInterface GQL schema and the price_range field, then inspect the preference in app/code/Magento/CatalogStorefrontGraphQl/etc/di.xml and the Deprecated/PriceRange resolver it names. Done means the price_range field is covered by the Storefront API and the deprecated resolver logic is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.