Magento 2.3.4 JS-Translations fall back to default store language
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 176
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Description
Edit by @DrewML: Bug has been fixed, but a more thorough solution should still be implemented. See later comments in thread for more details
Original Issue
In a multistore setup with different languages, some translations like for "Total" in checkout cart or the ones for the "add to cart" button, just after clicking it, fall back to the ones given for the default store view.
This only happens with the Baler module being enabled.
A colleague of mine debugged it to magento/module-translation/view/base/web/js/image-translation-dictionary.js
This was introduced in the following commit:
https://github.com/magento/magento2/commit/71c781df5536a2ec79c9cf42ade0c262396767a3
Which was seen as a resolution for
https://github.com/magento/baler/issues/13
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with magento/module-translation/view/base/web/js/image-translation-dictionary.js and read the referenced Magento and Baler issue commits, then review the later comments for the proposed thorough solution. Reproduce the multistore case with Baler enabled, including checkout and add-to-cart translations. Done means non-default store views retain their configured translations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100