magento / magento/architecture
Can we provide a list type while creating a list?
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 278
- Forks
- 146
- PR merge metrics
- No merged PRs in 30d
Description
Hello Team,
We are working on the Wishlist feature in the PWA project ahead of the coverage being available through GQL. We are following the architecture doc for guidance on what to expect from queries and mutations.
While building the feature we have realized the createWishlist mutation does not take the type of the list, for instance, public or private. On the other hand, the Wishlist interface does have a field called sharing_code. Is sharing_code the list type value that we should be expecting and how should we submit the list type while creating the list?
Here is the UX we are following:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked design document at design-documents/graph-ql/coverage/customer/Wishlist.graphqls, focusing on the Wishlist interface and createWishlist mutation. Compare the mutation inputs with the requested public/private list type and determine the expected schema behavior; done means the API contract is clarified and any required architecture change is specified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- graphql
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100