magento / magento/architecture
Developer experience: getData should log warnings when an attribute is not loaded
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 278
- Forks
- 146
- PR merge metrics
- No merged PRs in 30d
Description
Is is a common issue to try to fetch data from objects like products with `$product->getData('attribute')` but depending on the source of those objects (for example if they come from an collection) the attribute is not loaded.
I would suggest to at least add a warning
if (!$this->hasData('attribute')) {
$logger->warning('Trying to access not existing / not loaded attribute');
}
This would improve the developer experience.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the implementation of getData and hasData and read how attribute access currently behaves. Define done as warning when an attribute is not loaded, while preserving normal access for loaded attributes; verify the behavior with the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- developer-experience
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100