magento / magento/architecture

Clean up Zend_Measure

Open
#176 0 comments 1 reaction 1 assignee View on GitHub

@YevSent is already working on this.

Since Jul 29, 2019.

Dominant language
No language data
Stars
278
Forks
146
PR merge metrics
No merged PRs in 30d

Description

The shipping modules (Shipping, DHL, UPS) all use Zend_Measure as either constants for measurements or the Zend_Measure_Length and Zend_Measure_Weight classes. For the constants I would suggest that we could migrate them into the Magento Shipping module as either constants or getters for these values. For the classes I am not too sure what the best option would be. Zend has moved away from these sort of modules in preference for We're primarily leveraging PHP's ext/intl http://zend-framework-community.634137.n4.nabble.com/zf2-zend-measure-is-gone-td4656526.html

  1. Is there a current plan for this sort of migration?
  2. There are no dependency defined in app/code/Magento/Dhl/etc/module.xml towards Magento Shipping event though it uses constants and exceptions from this module.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.