magefree / magefree/mage

[BUG] Theros gods are removed from combat if turned into a creature through an effect

Open
#9,918 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

![image](https://user-images.githubusercontent.com/11657716/215229062-7f997349-e930-46cf-8d3f-dbe310c87f10.png)

In this game, [[Thassa, God of the Sea]] attacked multiple turns after being turned into a creature by [[Zur, Eternal Schemer]]'s ability. But immediately after attacking, she was removed from combat. I suspect that Thassa's static ability is checked during state-based actions, making her not a creature and removing her from combat, and then Zur's effect is checked, turning her back into a creature.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the interaction between Thassa, God of the Sea, Zur, Eternal Schemer, and the effect that turns Thassa into a creature. Start by comparing the creature status immediately after attacking with the state-based-action handling described in the report. Done means Thassa remains in combat when the effect still makes her a creature.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.