magefree / magefree/mage

Tests with wrong choice must be researched and fixed

Open
#9,594 1 comment 0 reactions 0 assignees View on GitHub
bug refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

There are many tests with possible wrong choices (~126 tests). It's can be by design (use case requires an invalid or empty choice) or it's can be an error (miss choice setup).

Possible fixes:
* add correct choice commands;
* add `checkPlayableAbility` command instead real cast with wrong choices;

How to find:
* in test logs by `Wrong choice`
* in source code by `//Assert.fail("Wrong choice");`

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing test logs for “Wrong choice” and searching the source for `//Assert.fail("Wrong choice");`. For each of the roughly 126 tests, determine whether the choice is intentional or indicates missing setup, then apply the appropriate listed fix. Done means the intentional cases are documented or handled and erroneous wrong-choice failures no longer occur.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev, testing-qa
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.