Rules-modifying effects prohibiting spell casting need to be updated
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
The rules for "Players can't cast {quality} spells" have changed several times over the last decade and xmage currently implements a mishmash of several outdated versions of them. Two concrete examples:
- ~~Effects that say "Players can't cast creature spells" should still allow a player to cast a spell with bestow in its Aura mode, and conversely effects that say "Players can't cast noncreature spells" should prevent players from casting bestow spells as Auras. Currently xmage always treats the spell as a creature spell. This rule was changed in 2015, with the release of Magic Origins.~~ [edit: this was fixed by #11178]
- Conversely, if an effect says players can't cast spells with a certain name, a player should not even be able to begin the spell casting process unless there is some choice they could make that would change the spell's name (e.g. it is an MDFC, a card with disturb in their graveyard, or a card with morph cast face down so it has no name). xmage allows them to put the spell onto the stack and only checks legality after it is on the stack, which was how the rules worked between 2015 and 2018 (the rule was changed shortly after the release of Dominaria to "fix" the admittedly flavorful but bizarre and counterintuitive interaction between [[Ixalan's Binding]] and [[Squee, the Immortal]]).
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.