magefree / magefree/mage

-fullscren option for MacOS is no longer supported when building on Java 9+

Open
#9,354 0 comments 0 reactions 0 assignees View on GitHub
bug GUI linux / macos
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Currently the client has a `-fullscreen` option for automatically starting the game in fullscreen on macOS. As of java 9+ the current approach we are using will not longer work (the classes used have been removed):
https://github.com/magefree/mage/blob/d42f9f1eca3a734b024e46e78eeadc658106c485/Mage.Client/src/main/java/mage/client/util/MacFullscreenUtil.java#L38-L55

We either need a new method for doing this, or to simply remove the option and require the users to fullscreen the application manually.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with Mage.Client/src/main/java/mage/client/util/MacFullscreenUtil.java, especially the Java classes referenced at lines 38-55, and trace how the -fullscreen option invokes them. Check the Java 9+ build or runtime path and determine whether fullscreen can remain supported or the option should be removed; done means the macOS client no longer relies on removed classes and the chosen behavior is clear.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, macos
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.