magefree / magefree/mage

Too easy to accidentally draw game during infinite combo

Open
#9,139 1 comment 0 reactions 0 assignees View on GitHub
enhancement GUI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

I was trying out xmage using my current favorite EDH deck: Brago. The deck has multiple potential infinite combo win conditions, such as Altar of the Brood + Deadeye Navigator + Perigrine Drake or Altar of the Brood + Brago + Strionic Resonator + Sol Ring.

After entering one of these loops to win the game, after some amount of cycles the game asks if I want to draw due to infinite looping. If I press f2 during this dialog, as I would have been doing while letting triggers resolve, then the game ends in a draw.

The easiest solution to this issue is to add an option in preferences to disable that prompt. Another alternative solution is to move the draw question to a separate popup window. Or make the default option "no". Or still show the question, but add a preference to allow user to change the default option.

A more involved solution would be to re-implement the infinite loop functionality (https://github.com/magefree/mage/issues/8392) or to adjust the handling of loops to match the MTG rulebook as mentioned in https://github.com/magefree/mage/issues/6212

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the infinite-combo draw prompt using the Brago deck scenarios described in the issue, then inspect the handling of the prompt and loop behavior. Review issues #8392 and #6212 for related design context. Done should prevent pressing F2 while resolving triggers from accidentally choosing a draw, with the final interaction matching an agreed solution.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.