magefree / magefree/mage

Add print date to TableModel

Open
#8,745 1 comment 0 reactions 0 assignees View on GitHub
enhancement GUI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

When editing a deck, this would be very helpful for finding a printing of a card that was printed within a certain time frame. Maybe put it between the “Card number” and “Draft Rating” columns. Just displaying the year is probably sufficient, but for sorting purposes, it would make sense to use the full date in `mage.client.deckeditor.table.MageCardComparator.compare`.

The following classes would need to be touched:

- [`mage.client.deckeditor.table.TableModel`](https://github.com/magefree/mage/blob/master/Mage.Client/src/main/java/mage/client/deckeditor/table/TableModel.java)
- [`mage.client.deckeditor.table.MageCardComparator`](https://github.com/magefree/mage/blob/master/Mage.Client/src/main/java/mage/client/deckeditor/table/MageCardComparator.java)
- [`mage.client.deckeditor.CardSelector`](https://github.com/magefree/mage/blob/master/Mage.Client/src/main/java/mage/client/deckeditor/CardSelector.java)

The print date is accessible via `mage.cards.ExpansionSet`. I didn't see a convenient way to obtain the relevant `ExpansionSet` instance. I don't work with Java, but I think that you can get the release date from a `CardView` object as follows:

```java
Date releaseDate;
ExpansionSet set = Sets.getInstance().findSet(cardView.getExpansionSetCode());
if (set != null) {
releaseDate = set.getReleaseDate();
}
```

`ExpansionSet` also has a `getReleaseYear()` method.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.