magefree / magefree/mage

"If {A} attacks, {B} attack if able" effects are impossible to implement correctly

Open
#8,595 3 comments 0 reactions 0 assignees View on GitHub
bug refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Attack requirement effects are currently only checked once per combat, before the active player has declared any attackers. This is good enough for most requirements, but it doesn't work for effects that depend on which other creatures are attacking.

Affected cards:

[[Ekundu Cyclops]] (not implemented in xmage, see https://github.com/magefree/mage/pull/8594)
[[Magnetic Web]] (not implemented in xmage)
[[Viashino Bey]] (currently implemented, incorrectly, as a triggered ability)
[[War's Toll]] (currently implemented, incorrectly, as a *restriction* effect)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.