magefree / magefree/mage

RemoveCounterCost could use improvements in target selection

Open
#8,440 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

The RemoveCounterCost class (used in VOW by Hopeful Initiate) could use some improvements in selecting targets to remove counters from.

- canPay only checks if there are valid targets on the board (so any creature on the board means the ability highlights as available to use even if there are not enough counters to pay).
- It allows the player to target a creature with no counters.
- May want to use the multi-target UI from #7528 when there is more than one target

This doesn't actually break gameplay. The pay function works correctly and it just backs out if there's not enough counters among targeted creatures but it would be a nice QOL to fix this up.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.