magefree / magefree/mage

Abilities and effects which care about attackers and blockers which have left the battlefield need to be streamlined

Open
#8,371 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Example: `BlockedByIdPredicate` and `BlockingAttackerIdPredicate` are used in card constructors with the card's UUID, which doesn't work if an ability is copied elsewhere.

Example: [[Kardur, Doomscourge]] uses a special triggered ability when there should ideally be a filter/predicate that can match dead attackers

My implementation of [[Baneclaw Marauder]] in #8200 can hopefully be generalized for this.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading BlockedByIdPredicate and BlockingAttackerIdPredicate, especially how card constructors supply the card UUID. Compare Kardur, Doomscourge's special triggered ability with the Baneclaw Marauder implementation referenced in #8200. Done means the behavior for copied abilities and attackers or blockers that left the battlefield is handled through a generalized predicate or filter.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.