magefree / magefree/mage

Refactor: game.getPlayers() must be changed to range related code

Open
#8,348 1 comment 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Calls like `game.getPlayers().values()` in cards/effects/abilities are incorrect -- it returns all players, but must return only players in the controller's range. So cards code (not game engine/global) must be replaced by:
* `game.getState().getPlayersInRange(source.getControllerId(), game)`

Affected uses: ~20-40.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.