magefree / magefree/mage

Game init errors must ends the game, not freeze it

Open
#8,043 0 comments 0 reactions 0 assignees View on GitHub
bug server
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Use case:
* Run server in [test mode](https://github.com/magefree/mage/wiki/Development-Testing-Tools#server-test-mode) (e.g. without deck validation);
* Start Tiny Leaders game with auto-generated deck (in normal situation commander/leader name must be in deck name);
* Game started, you will see empty battlefield, but no player selecting -- it's a game freeze. Error log goes to `magediag.log`;

Game must ends normally after fail on starting/init.

Error generating error from `GameTinyLeadersImpl`:
https://github.com/magefree/mage/blob/9698e3488ffee21ebfbfc658e1ea68f6bbf52d44/Mage/src/main/java/mage/game/GameTinyLeadersImpl.java#L77-L81

Error processing code from `GameWorker`:
https://github.com/magefree/mage/blob/754a5b38ebba104b83494629c1f3881020168b1e/Mage.Server/src/main/java/mage/server/game/GameWorker.java#L30-L49

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.