magefree / magefree/mage

GUI: wrong packs pool selection dialog in tourney window

Open
#8,040 0 comments 0 reactions 0 assignees View on GitHub
bug enhancement GUI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Tourney -> Booster Draft Elimination (Rich Man)

It allows to select sets list for draft, but choose dialog is bugged (wrong element sizes). Maybe it can be replaced to `PickCheckBoxDialog`.

TODO that can be done:
* [x] fix choose dialog sizes;
* [ ] replace sets select dialogs with `PickCheckBoxDialog`;

Wrong sizes bug:
![shot_210723_195445](https://user-images.githubusercontent.com/8344157/126809373-33f5ff9b-da5b-4ce7-b225-5b2e7396abf3.png)

`PickCheckBoxDialog` example (Deck Editor):
![shot_210723_200709](https://user-images.githubusercontent.com/8344157/126810418-063039dd-899c-48c7-a243-00ee019e29fa.png)

`PickChoiceDialog` example (images download):
![shot_210723_200557](https://user-images.githubusercontent.com/8344157/126810274-c0b1e6c5-0578-4642-8d88-a90d8250bb61.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the Tourney → Booster Draft Elimination (Rich Man) flow and inspect the sets-selection dialogs, comparing them with the PickCheckBoxDialog example from the Deck Editor. Done means the dialog sizes are correct and the sets-selection dialogs use PickCheckBoxDialog where appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.