magefree / magefree/mage

Refactor: Rework continuous effect dependencies

Open
#8,007 9 comments 0 reactions 0 assignees View on GitHub
bug enhancement refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Right now our system for continuous effects and dependencies isn't robust. There are two major aspects to this:

1. Properly determining which effects are dependent on others, which is currently only done on the gain ability layer (it's also important to check this on control-changing effects)
2. Handling dependencies once determined, especially dependency loops, which can be done via directed graphs. Our current implementation has issues with more complex dependency loops.

This is something I want to work on once we're done implementing AFR but I wanted to at least open this issue now.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.