magefree / magefree/mage

Stop the sound cues from completed games

Open
#6,850 1 comment 0 reactions 0 assignees View on GitHub
bug enhancement
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

This is usually only an issue with high latency or multi-player AI games, but sound cues will always play in their entirety and in order. If you get enough of them stacked up, they'll keep playing long after the game that triggered them is over (and delaying any sound cues from your new game(s) until they finish). Ideally, sound cues from a completed game should be ignored and tossed out without being played.

An easy way to reproduce this is to start a three player game with two AIs and decks that enable them to attack repeatedly - I used 40 Black Lotus, 20 Atris, Oracle of Half-Truths - then concede the game. The two AIs play out the remainder on hyper-speed, stacking up sound commands for attacking and turn passing to the point where - even after the game ends - there's a solid minute or two of sound cues going off.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.