magefree / magefree/mage

stop hitting yourself: a quick review of the code of some cards

Open
#6,844 4 comments 0 reactions 1 assignee Claimed by @jeffwadsworth View on GitHub
AI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

In light of the issue #6838 I searched for a bunch of cards that are somewhat similar to _Beast Within_ and then look into their code looking for their _outcome_ constants, if any, to see if there are other that might need similar treatment as the aforementioned card, and the following are the cards I found:

- Afterlife
- Generous Gift
- Pongify
- Rapid Hybridization
- Cavalier of Dawn
- Essence Vortex
- Geomancer's Gambit
- Transmogrifying Wand

For _Assassin's Strike_ and _Desecrated Earth_ the outcome said its draw a card, but it should be discard

_Bomb Squad_: Maybe? I don't know what part of it the AI use to select targets, but you don't want to put those counters on your stuff... usually

_Glissa's Scorn_: If I understand the code correctly, is market as it prevent regeneration, but that is not the case with this card.

And finally for this last few I'm not sure or is debatable I guess:
Nature's Claim
Descent of the Dragons
Ob Nixilis, the Hate-Twisted
Ghost Quarter (I actually like its current behavior, but I included it here for completeness)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.