magefree / magefree/mage

Wrong keyword ability hints (Menace, Scry and other)

Open
#6,728 0 comments 0 reactions 0 assignees View on GitHub
cards tracking tasks
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Keyword abilities can have special hint text with ability description. But some cards don't have that hint. It uses only ability keyword.
* Menace (This creature can't be blocked except by two or more creatures.) (example: [Belle of the Brawl](https://scryfall.com/card/eld/78/belle-of-the-brawl))
* Menace (example: [Alley Strangler](https://scryfall.com/card/aer/52/alley-strangler))

TODO:
* [x] `MenaceAbility`
* [x] `ScryEffect`
* [ ] Improve singleton abilities to support different settings, see #6731;

I improved `verifyCards` unit test to find that problems. Find that text and enable it to see full list of wrong cards. Current wrong list includes ~200 cards. It can be improved by new keywords later:
* `TODO: enable and fix all problems with effect and ability hints`
![shot_200626_124917](https://user-images.githubusercontent.com/8344157/85839045-7a74ff80-b7ab-11ea-9ae4-b40518394e29.png)
![shot_200626_124130](https://user-images.githubusercontent.com/8344157/85838282-611f8380-b7aa-11ea-9066-be20c1a4ba0a.png)

How to fix: change ability's constructor param to enable or disable hint:
![shot_200626_124653](https://user-images.githubusercontent.com/8344157/85838774-210cd080-b7ab-11ea-872a-766b91865b13.png)

P.S. Verify tests compare xmage's cards with [mtgjson](https://mtgjson.com/)'s data (scryfall and other).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.