magefree / magefree/mage

Game thinks some spells can be cast when they can't

Open
#6,702 1 comment 0 reactions 0 assignees View on GitHub
bug tracking tasks
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Extension of related issue #6698

Note that not all of these will need to be changed - some may be intentional due to the difficulty of knowing when a card might be legal to cast; it's better to allow more freedom than less.

# Still Bugged
- [ ] Castle Garenbrig - thinks it can be used to cast non-creature spells, like Caged Sun
![image](https://user-images.githubusercontent.com/59861365/86622152-0396ee00-bf85-11ea-8bfd-80a7fb6dac36.png)

- [ ] Eldrazi Temple - thinks it can add {2} for any spell, not just eldrazi
![image](https://user-images.githubusercontent.com/59861365/86818935-9fd7f800-c04c-11ea-9f72-4b8cba73c2cc.png)

- [ ] Kentaro, the Smiling Cat - Samurai think they can all be cast with Kentaro in play, even if you have no mana available
![image](https://user-images.githubusercontent.com/59861365/86545387-2cbb6e00-bef4-11ea-8de5-0a2357a8685f.png)

- [ ] Rosheen Meanderer - gets considered for whether spells can be cast even when they don't have X in their cost
![image](https://user-images.githubusercontent.com/59861365/86542862-21aa1300-bedf-11ea-9425-ae86e8279372.png)

- [ ] Sanctum Prelate - cards locked out by Sanctum Prelate still think they're castable
![image](https://user-images.githubusercontent.com/59861365/85343233-f58b9c80-b4b1-11ea-9a4a-ff836c240353.png)

- [ ] Sunglasses of Urza - cards seem to think this allows for rainbow mana instead of just red mana
![image](https://user-images.githubusercontent.com/59861365/88489199-88f43980-cf58-11ea-8f48-432bf3f2fe60.png)

# Fixed

- [x] Chandra's Embercat - thinks it can be used to cast any spell, not just elementals and Chandras.
![image](https://user-images.githubusercontent.com/59861365/86623168-b74cad80-bf86-11ea-95fe-17461dbbca3e.png)

- [x] Dalakos, Crafter of Wonders - gets counted at CC for all spells, not just those it can help cast
![image](https://user-images.githubusercontent.com/59861365/86545450-afdcc400-bef4-11ea-8f39-be1701e60226.png)

- [x] Daze - thinks it can be cast with no islands in play and no mana sources
![image](https://user-images.githubusercontent.com/59861365/85346119-1ce66780-b4ba-11ea-8a2b-c7d5a8d53f19.png)

- [x] Firemind Vessel - two vessels think they can cast Archangel of Tithes, but because they have to make different colors of mana, they can't
![image](https://user-images.githubusercontent.com/59861365/87101395-9e592c00-c214-11ea-897f-d534b33f4e7f.png)

- [x] Geosurge - thinks the mana can be spent on any spell, not just creatures and artifacts
![image](https://user-images.githubusercontent.com/59861365/87100560-5507dd00-c212-11ea-9fbf-244cae5fde2f.png)

- [x] Grand Architect - thinks the mana can be spent for any spell, not just artifacts
![image](https://user-images.githubusercontent.com/59861365/87100059-03ab1e00-c211-11ea-9a08-ca0ad5b5dd3a.png)

- [x] Gnarlroot Trapper - thinks the mana can be spent on any spell, not just elves
![image](https://user-images.githubusercontent.com/59861365/87100647-98624b80-c212-11ea-8915-86a977698214.png)

- [x] Guild Globe - two globes and four islands think they can cast Archangel of Tithes, but because they have to make different colors of mana, they can't
![image](https://user-images.githubusercontent.com/59861365/87101336-77025f00-c214-11ea-9dd3-281423e84c9e.png)

- [x] Jodah, Archmage Eternal - every card thinks it can be cast if Jodah is on the battlefield, even if you have no mana to pay for the ability.
![image](https://user-images.githubusercontent.com/59861365/86545039-56bf6100-bef1-11ea-8c81-d7845f5ae5ed.png)

- [x] Rhystic Cave - is being treated as a mana source, which it kind of isn't since you can only activate it at instant speed; it should be closer to how we handle Arbor Elf (i.e. don't count it for calculations)
![image](https://user-images.githubusercontent.com/59861365/88471556-5b63ad80-ced0-11ea-8618-789268e1a0dd.png)

- [x] Sivvi's Valor - thinks it can be cast for free, even if you don't have a plains
![image](https://user-images.githubusercontent.com/59861365/86615060-8f0a8200-bf79-11ea-85b4-9cd6756ef347.png)

- [x] Willbender - thinks it can be cast at all times - including during my opponent's turn with no mana sources available. (It will only let you put it *on the stack* at sorcery speed, though it still doesn't check for any available mana sources when doing so)
![image](https://user-images.githubusercontent.com/59861365/85312821-00780a00-b47d-11ea-8cd9-5c9d74e202d3.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.