Server can remove normal table on healthy check
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
Not critical bug.
Found rare bug with non started games (server logs shows `has no deck` error) -- on last 4 days it raises only 3 time on de-server.
```
WARN 2020-01-09 21:10:21,603 Removing unhealthy tableId d34318b2-e9e6-47e5-836d-dfd07029c4e1 =>[pool-10-thread-1] TableManager.lambda$checkTableHealthState$2
ERROR 2020-01-09 21:10:21,626 Match: 614df0ad-dcdf-4fd2-87a7-3876f9c3d5d2 RobbyJ has no deck. =>[GAME 08fd92d8-9d01-4d6a-82c5-e373d528396d] MatchImpl.initGame
ERROR 2020-01-09 21:10:21,633 Match: 614df0ad-dcdf-4fd2-87a7-3876f9c3d5d2 SpeedNeo7 has no deck. =>[GAME 08fd92d8-9d01-4d6a-82c5-e373d528396d] MatchImpl.initGame
```
Found only one place that can cause that -- it's table remove in `checkTableHealthState` -> `isMatchTableStillValid`. If the healthy check call (once per 10 minutes) gets between two games with sideboarding then bug possible (user reported that there were no sideboard window -- new game started immediately):
> Xmage skips sideboarding and goes directly to the next game after someone concedes. Then it gets stuck into that screen


Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.