magefree / magefree/mage

Wrong color replacement in BecomesCreature effects

Open
#4,905 0 comments 0 reactions 1 assignee Claimed by @JayDi85 View on GitHub
bug cards tracking tasks
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

MTG rules 105.3:
> Effects may change an object’s color or give a color to a colorless object. **If an effect gives an
object a new color, the new color replaces all previous colors the object** had (unless the effect said
the object became that color “in addition” to its other colors). Effects may also make a colored
object become colorless.

Example fix: 72314a9512ea787434bce4599af11d26777b5f5f

There many methods to check (search source by `case ColorChangingEffects_5`):
* [x] FIXED: BecomesBlackZombieAdditionEffect.java
* [x] FIXED: BecomesCreatureAllEffect.java
* [x] OK: BecomesCreatureAttachedEffect.java
* [ ] TODO: BecomesCreatureAttachedWithActivatedAbilityOrSpellEffect.java (need to replace it with standard code)
* [ ] BecomesCreatureSourceEffect.java
* [ ] BecomesCreatureTargetEffect.java
* [ ] BecomesFaceDownCreatureAllEffect.java
* [ ] BecomesFaceDownCreatureEffect.java
* [ ] ContinuousEffectImpl.java
* [ ] DralnusCrusade.java
* [ ] GrimoireOfTheDead.java
* [ ] ImprisonedInTheMoon.java
* [x] OK: LiegeOfTheTangle.java
* [ ] LifeAndLimb.java
* [ ] PolymorphistsJest.java
* [ ] SarkhanTheDragonspeaker.java
* [ ] SongOfTheDryads.java
* [ ] TestamentOfFaith.java
*
* [ ] Add dependency on BecomeCreature
* [ ] Check and test "in addition" effects (must save or remove other creature types from card on effect)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.