magefree / magefree/mage

Check if source object is still the same as an ability was put on the stack.

Open
#4,893 7 comments 0 reactions 1 assignee Claimed by @xenohedron View on GitHub
bug refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

I recently fixed a bug of Wall of Deceit. The "Turn face down" ability did not work.

In the fix I added some logic to prevent, that the effect works, if the Wall was Blinked (e.g. with Momentary Blink) between adding the ability to stack and the resolving of the ability.
I guess that way to handle it is correct, if the ability on the stack is related to a previous permanent onto the battlefield.

Also some confirmation for that rule interpretation from rule gurus is appreciated. I 'm pretty sure the ability on the stack does simply nothing (even not fizzle because targets are not involved), if the object the ability was created from is no longer on the battlefield.

But by checking it this way, I realized that there are a ton of abilities related to source (without using a target) that probably need a similar handling.

Take as an example Drudge Sentinel. It has the following ability:
// {3}: Tap Drudge Sentinel. It gains indestructible until end of turn.
If you activate its Tap/get indestructible ability and the Sentinel was blinked before resolution of the ability. The ability should do nothing but currently it resolves and taps the Sentinel and adds indestructible to it.

Am I right, that this kind of abilities are not handled correctly currently?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.