magefree / magefree/mage

Game freezes on disconnected player's commander dying

Open
#4,262 8 comments 0 reactions 0 assignees View on GitHub
bug server
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

This is related to the more general issue of disconnected (not conceded!) players' permanents persisting on the battlefield which I'm sure was reported here at least once before. Just for clarity's sake: If a player loses connection, his board "folds in" like during a game loss, but the permanents are still there and interact with other players/permanents as normal. A Null Rod owned by a disconnected player still shuts down activated abilities of artifacts, etc.

Arguably the most commonly seen and egregious part of this issue however happens in EDH games: **if such a player has his commander persist on the board this way and the commander is forced to change zones somehow after the disconnect happens (typically if killed by a Wrath of God effect), the game lingers on forever as it waits for the now-unavailable player to make the decision to move the commander to the command zone.** The player can't even time-out, since the game already seems to consider him "gone".

Since the whole disconnect-persist issue is most certainly a complex matter to solve, I'd love to see at least this part sorted out for now - perhaps there could be a new "player.choose" method for commander zone-changing that has a built-in time limit? If it times out, it'd move the commander to the command zone automatically.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.