magefree / magefree/mage

GamePanel zone windows should reference player by ID instead of by name.

Open
#2,647 0 comments 0 reactions 0 assignees View on GitHub
enhancement GUI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Due to how the methods work for showing various player zones (e.g. [openGraveyardWindow](https://github.com/magefree/mage/blob/master/Mage.Client/src/main/java/mage/client/game/GamePanel.java#L1060)), if multiple players (typically bots) have the same name, then the first instance of the player with the selected name will be used.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in Mage.Client/src/main/java/mage/client/game/GamePanel.java at openGraveyardWindow and inspect the related zone-window methods. Trace how the selected player is looked up, then update the affected references to use player IDs so players with duplicate names open the correct zone window.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.