magefree / magefree/mage

Savor the Moment - Skips Untap of Wrong Turn

Open
#2,008 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

# Issue

Savor the Moment always skips the untap step of the casters next turn, whether that is the "that turn" referred to by Savor the Moment or not. That means that when there are multiple extra turns queued up, Savor the Moment may skip the untap step of the wrong one.
# Reproduction Steps:
- Cast Savor the Moment
- Cast Time Warp (This extra turn is inserted ahead of Savor the Moment in the extra turn queue)
- Pass Turn
- Untap Step will be skipped, even though this should be the extra turn from Time Warp, not the "that turn" from Savor the Moment
# Fixing

Extra turns don't appear to have any sort of ID that the untap step skipping effect can identify the turn to skip by, so fixing the bug would require either making turns into first class objects (such that the untap step of the first class turn object in the turn queue could be removed), or short of that, at least adding an identifier of some sort to "take an extra turn" effects (so that the skip untap step TurnMod can identify which turn to affect).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.