magefree / magefree/mage

Thriving land text template changed

Open
#15,969 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Oracle text for Thriving lands that enter tapped and allow you to choose a color as they enter changed from being two lines to being phrased as a single item;

e.g.

From:

```
Thriving Moor enters the battlefield tapped.

As Thriving Moor enters the battlefield, choose a color other than black.
```

To:

```
This land enters tapped. As it enters, choose a color other than X.
```

I attempted to fix this text generation by chaining the choose effect off of the enters-tapped ability with a `.setText()` override, but per #15967 this did not work as expected. The additional effect never presented on the rules generated, nor did it kick in.

Need to dig a bit into:
* Why this didn't work as expected
* Also fixing the rule templating to align as originally attempted

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the failed attempt to chain the choose effect from the enters-tapped ability with a .setText() override, then read issue #15967 for the related behavior. Trace how Thriving land rules text is generated and verify that the choose effect both appears in the generated rules and takes effect, using the single-item wording described here as the target.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.