magefree / magefree/mage

Various typal cards filter for creatures unnecessarily

Open
#14,302 11 comments 0 reactions 0 assignees View on GitHub
bug refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Inspired by #14299

A lot of cards which refer to a particular creature type will have a filter that only filters for creatures when the effect in question could apply to a noncreature kindred permanent. For a long time this rarely came up, but now with the printing of [[Firdoch Core]] it's important that these cards be fixed.

The biggest issue here is just how tedious it is to check every card that it could apply to. I created a [scryfall search](https://scryfall.com/search?q=otag%3Anoncreature-typal+-is%3Areprint+&unique=cards&as=grid&order=released&dir=asc) that should cover most if not all the cards this applies to, but after doing a single results page (693cd16) it became clear that there needs to be a better approach to handling this.

Any ideas would be welcome.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Scryfall search linked in the issue and inspect the single-results-page work in commit 693cd16. Compare the affected typal card filters with the Firdoch Core case and the discussion in #14299. Done means identifying a maintainable approach and applying it to all applicable cards, rather than checking them manually one page at a time.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.