Review usage of GameEvent.BEGINNING_PHASE_PRE and replace most of them by BEGIN_TURN
Open
refactoring
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
from comment https://github.com/magefree/mage/commit/0dceeb78bdae2cff9362d152a568ef2954877a6d#r161989958
The `BEGIN_TURN` just got added, and is guarantee to only trigger once per turn.
Issue with `BEGINNING_PHASE_PRE` is that there could be no beginning phase, or multiple ones ([[Shadow of the Second Sun]] already exist), and the watcher and/or trigger logic relying on the event may not handle that well.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.