magefree / magefree/mage

Bugs with watcher scope implementation

Open
#13,774 7 comments 0 reactions 1 assignee Claimed by @xenohedron View on GitHub
bug Developers Discussion refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

[[Diseased Vermin]] uses a custom watcher with scope GAME to track status specific to a permanent.

Direct usage of `sourceId` field looks bad, only makes sense for a CARD scope watcher.

But... CARD scope watcher logic I think is fundamentally bugged for this usage anyway, because it doesn't check zcc.

Maybe should consider refactoring every watcher to GAME scope and no longer using PLAYER/CARD scope watchers at all.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.