magefree / magefree/mage

Refactor: target's setRequired must be removed and replaced by 0, 1 settings

Open
#13,754 0 comments 0 reactions 1 assignee Claimed by @JayDi85 View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Need more research. Looks like target's `setRequire` (also `isRequired`) rare used and can be removed. It's outdated and weird logic to make target choose dialog a cancellable like cost payment dialog. Used for AI and human players in some choose target dialogs.

Actual logic for optional targets -- set 0, 1 to num targets. No needs in cancel buttons at all.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.