Refactor: cleanup Spellbane Centaur + CantBeTargetedAllEffect
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
See TODOs in https://github.com/magefree/mage/commit/77613ad318375c6ce00eedb8d50a615e80a36fe7
`CantBeTargetedAllEffect` should have a `TargetStackObject` instead of `TargetObject` for "targetSource", and various constructor should only support `FilterStackObject`.
Card most likely deserve unit tests.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with commit 77613ad318375c6ce00eedb8d50a615e80a36fe7 and inspect its TODOs, then trace Spellbane Centaur and CantBeTargetedAllEffect. Review the targetSource type and constructors mentioned in the issue, and identify the relevant card tests. Done means the requested type and constructor cleanup is complete and affected behavior is covered by unit tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100