magefree / magefree/mage

Support multi-zone TargetCard

Open
#13,697 2 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Out of https://github.com/magefree/mage/pull/13694#discussion_r2114442743

As of now, TargetCard is set a single Zone, which is used in a few places, notably AI decisions.

However there are a few cards that actually have a target on different zones, like the new [[Sorceress's Schemes]]. I think it would make sense to either have a Set of `Zones`, or a side function that would take a `Zone` in argument and return true if cards in the zone can be targeted with that target.

There are also a few cases of `TargetCardInGraveyardBattlefieldOrStack` (e.g. [[Endless Detour]]) which should probably be included in the discussion of a generalized multi-zone target (`TargetCard` doesn't currently support `Spell` nor `Permanent` targetting)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.