magefree / magefree/mage

Refactor: make use of AttachedToSourcePredicate

Open
#13,669 1 comment 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

In https://github.com/magefree/mage/pull/13666/files#diff-c3e8c1270783e0e346fa33c750998e7053c9bf588eeebcf269efb00f46d36043 I did introduce an AttachedToSourcePredicate for the needs of [[Tetsuo, Imperial Champion]].

There are certaintly cards among https://scryfall.com/search?q=o%3A%22attached+to+it%22+or+o%3A%22attached+to+%7E%22&unique=cards&as=grid&order=name that could use the predicate to simplify their custom effects.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the AttachedToSourcePredicate introduced for Tetsuo, Imperial Champion in pull request #13666. Examine the cards returned by the linked Scryfall search and identify custom effects that express the same attached-to-source behavior. Done means applicable effects use the predicate without changing their existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.