magefree / magefree/mage

Refactor: CreateTokenEffect of X power and/or toughness token

Open
#13,668 0 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

There are many token creation effect that have some on-apply knowledge of token parameter.

I think we could have an effect to create those token along a dynamic value, in order to lessen the need for custom effect instantiating the tokens.

https://scryfall.com/search?q=o%3A%2Fcreate.*X%5C%2F.*token%2F+or+o%3A%2Fcreate.*.%5C%2FX*token%2F&unique=cards&as=grid&order=name

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the existing token creation effects and the Scryfall search linked in the issue to identify cases involving X power or toughness. Compare how those effects currently receive token parameters and define the shared behavior needed; done means the relevant cases can use the common effect without custom token-instantiating effects.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.