magefree / magefree/mage

GUI: undo button is useless in declare attackers/blockers dialog

Open
#13,621 0 comments 0 reactions 0 assignees View on GitHub
bug GUI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

That's button restore to last permanent only, not to original state before selection started.

Current bugs:
* do not refresh GUI's selections after undo
* if you choose attackers/blockers one by one then that undo button will be useless -- it's rollback only last tap action;

Need research -- is it buggy or by design. Current human can click on permanent to select/deselect it, but single undo can be useful to restore after forced payment and other additional actions:
* `PayCostToAttackBlockEffect`

Possible solutions:
* fix selection bug
* fix rollback to original state, not single permanent

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the GUI declare attackers/blockers dialog and the PayCostToAttackBlockEffect path mentioned in the issue. Determine whether undo should restore the original selection or only the last permanent, and verify that GUI selections refresh after undo; done requires an agreed behavior and corresponding fix.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.