InfoEffect various static methods addInfoToXXX should not add an Ability to the target
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
InfoEffect various static methods have a convenient purpose: add some text to a permanent or card that is displayed to convey some kind of information to players.
However, it does not quite fit the rules as it adds a StaticAbility to objects to achieve its goal.
There are a few non-desirable consequences:
- [[Muraganda Petroglyph]] does exist
- The information can be lost on losing abilities.
I believe the intent is good, but it should be done storing the information outside of the objects abilities.
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate the InfoEffect class and its static addInfoToXXX methods, then trace how they attach StaticAbility instances to permanents or cards. Determine an alternative storage path that preserves displayed information without creating an ability or losing it when abilities are removed; done means the listed consequences no longer occur.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100