magefree / magefree/mage

refactor: research and fix target usage inside while cycles

Open
#13,606 0 comments 0 reactions 1 assignee Claimed by @JayDi85 View on GitHub
AI bug refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

All "while" cycles with target usages must be researched and fixed due many potential problems:
* cards: make sure player can choose;
* cards: make sure player can response (not need if you add false choose result stop, see below);
* cards: make sure you stop on false choose (bug: dialog freeze on impossible targets or game freeze on leave player);
* AI: make sure each call will remove selected id from a possible list (bug: ai game freeze on protected/wrong possible targets);

Reg exp search:
* `while .+ischosen`

Code example to check:
![Image](https://github.com/user-attachments/assets/c0a897c7-2822-4240-a358-321f796a1fd2)
![Image](https://github.com/user-attachments/assets/7cbbf6a3-0167-4dc8-8345-610aa8192c75)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.