magefree / magefree/mage

Refactor: miss copy of alternativeCastingCostAbility in effects

Open
#13,379 0 comments 0 reactions 0 assignees View on GitHub
bug refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Looks like copy constructor miss copy of cost in many effects. Must be research — is it by design or by typo and replace all usages to same code style (I think it must be copy).

Potential bugs: free cast in AI games, after rollbacks, spell copy or mana payment cancel.

Search code by `final AlternativeCastingCostAbility` or `alternativeCastingCostAbility`

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the codebase for `final AlternativeCastingCostAbility` and `alternativeCastingCostAbility`, then inspect the affected effect copy constructors. Determine whether each omission is intentional or a typo, and consider the stated free-cast, rollback, spell-copy, and canceled-payment cases; done means the affected usages consistently follow the intended copy behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.