magefree / magefree/mage

Refactor: jumpstart sets must use shared code to generate single boosters

Open
#13,264 4 comments 0 reactions 0 assignees View on GitHub
enhancement refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Jumpstart is special booster type of x20 cards. Cards split by themes instead random:
https://mtg.fandom.com/wiki/Jumpstart

Xmage support it by special jumpstart game mode only (see `JumpstartPoolGenerator` and `\resources\jumpstart\jumpstart.txt`).

Problems

1. [ ] There are 3 jumpstart sets, but only 1 supported:
* [x] 2020 - Jumpstart
* [ ] 2022 - Jumpstart 2022
* [ ] 2024 - Foundations Jumpstart
2. [ ] Jumpstart boosters supported by special game mode instead any;
3. [ ] Half decks jumpstart from [Ravnica: Clue Edition](https://mtg.fandom.com/wiki/Ravnica:_Clue_Edition)

What can be done:
* improved code of `JumpstartPoolGenerator` to use predefined boosters from all 3 sets instead 1;
* override `createBooster` and use shared code from `JumpstartPoolGenerator` to generate single boosters (see code example from `MysteryBooster`);
* so jumpstart boosters can be used in all other game modes after improve;

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.