magefree / magefree/mage

GUI: battlefield’s permanents auto-size logic must be reworked

Open
#12,902 0 comments 0 reactions 1 assignee Claimed by @JayDi85 View on GitHub
enhancement GUI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Current size logic:
- take max card size from gui settings and try to auto-size it until it will be fully visible in the row
New size logic:
- take current row size and calculate card size for it

Current problems and possible fixes:
- [ ] different height for own and opponent battlefields - must be same (red marks on screenshot example);
- [ ] wrong card size calculation, so it can’t show two rows without scrolls (blue marks on screenshot);
- [ ] potential zoom control must use “rows amount to show” instead card size — no needs in per pixel zoom level;
- [ ] recommended settings from GUI size preferences must setup default zoom level (rows to show) instead min/max card size on battlefield.

![IMG_0841](https://github.com/user-attachments/assets/a60f7f79-e624-4154-9249-fe489a36ee13)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.