magefree / magefree/mage

Refactor: aura's target legality check on attachment must be reworked (303.4g)

Open
#12,829 0 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Unfinished implementation from https://github.com/magefree/mage/pull/12098#issuecomment-2252622155 uses bad and limited workaround with data modification. Search bad code by `copy().withNotTarget(true)`

It must be reworked to use normal code and check like isStilLegal or like that -- without target modification and with full and mutiple targets support.

Also can be related 702.5. and #9583

Contributor guide

No contributing guide indexed for this repository

Research direction

Search for `copy().withNotTarget(true)` and review the unfinished implementation discussed in pull request #12098. Compare the attachment legality logic with checks such as `isStilLegal`, along with rule 702.5 and issue #9583. Done means the check uses normal code without target modification and supports full, multiple-target legality.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.