magefree / magefree/mage

NotManaAbilityPredicate must be removed as useless

Open
#12,827 6 comments 0 reactions 1 assignee Claimed by @ssk97 View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

`NotManaAbilityPredicate` uses stack objects. It's useless cause mana abilities don't use stack by mtg rules and game engine. So it must be removed and used cards must be checked -- is it really work as intended. Original discussion from https://github.com/magefree/mage/pull/12597#discussion_r1727818414

6 affected cards like [[Battlemage's Bracers]]:
![shot_240908_113226](https://github.com/user-attachments/assets/7ad3ecb6-1b6a-47bb-aee2-f89b1e491e15)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.