magefree / magefree/mage

GUI: rework auto-answers to use shared logic, rework day/night button

Open
#12,811 0 comments 0 reactions 1 assignee Claimed by @JayDi85 View on GitHub
enhancement GUI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Current problem: it’s almost the only one xmage’s GUI that hidden inside right click menu, so many players don’t know about that feature. Also touchscreens like mobile devices don’t have mouse (no right clicks, limited drag and drop).

Current support:
- feedback dialog with yes/no button — right click on button;
- trigger choose dialog — right click on trigger card;
- pick choice dialogs with search and other fields - unsupported (limited support, see replacement effects choose);
- ability choose dialog with transparent panel - unsupported;
- target choose dialog - unsupported.

Current examples:
![image](https://github.com/user-attachments/assets/a3f79ec5-8c83-4d5e-8293-9695edb196d2)
![image](https://github.com/user-attachments/assets/f7072257-327e-481d-8ead-de42e0ba6998)

Possible solution: use action button with additional drop down menu, so users can see another possible actions

Java swing library don’t have such controls so it must be implemented. Example implementation: https://stackoverflow.com/questions/63251187/how-to-create-a-combo-box-button

Style references:
![IMG_0762](https://github.com/user-attachments/assets/773f22ea-5aae-49ee-b0ba-697080a5c0ac)
![IMG_0765](https://github.com/user-attachments/assets/a6f2dff0-fee5-4be3-8698-5f1f98cf0028)
![IMG_0766](https://github.com/user-attachments/assets/6c3026b6-b9fb-4ecc-9d65-09f182b0d5fd)

Trigger choose dialog uses standard card panel (e.g. card render object), so it can have build-in action button, e.g. in the bottom of the card or in the corner (alternative to day/night button).

I think day/night UI can be improved and reworked to integrate all other actions like: switch card side, remember choice, report card bug, add/remove to favorite, etc.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.