Tracking issue: Reworking DynamicValue wrt effect text generation
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
Original discussion #12595
TODO:
- [ ] Get go-ahead on small PR implementing backwards-compatible changes with a few pertinent examples (#12596)
- [ ] Implement `getMessage(EffectPhrasing phrasing)` and possibly `getValueHint()` for all implementations of `DynamicValue`, merging in stages, Fixing any oracle text errors introduced
- [ ] A
- [ ] B
- [ ] C
- [ ] D
- [ ] E
- [ ] F
- [ ] G
- [ ] H
- [ ] I
- [ ] J
- [ ] K
- [ ] L
- [ ] M
- [ ] N
- [ ] O
- [ ] P
- [ ] Q
- [ ] R
- [ ] S
- [ ] T
- [ ] U
- [ ] V
- [ ] W
- [ ] X
- [ ] Y
- [ ] Z
- [ ] Add MultipliedValue handling to `getBoostText`
- [ ] Remove `getBoostCountAsStrLegacy`
- [ ] Sweep for any `DynamicValue` classes that dont need to be classes (i.e. owning multipliers)
- [ ] Sweep for `DynamicValue` implementations that can use decorators that were missed by the above due to not being classes (i.e. `MwonvuliOozePTValue`)
- [ ] Replace all Hint instances that can be replaced with a call to appropriate getValueHint()
- [ ] Sweep for effects with `DynamicValue` arguments, merging in stages
- [ ] Remove any removable uses of `setText()` for all effects using `DynamicValue`
- [ ] Remove `toString` in `DynamicValue`
- [ ] Remove `getMessage()` (no arguments) in `DynamicValue`
- [ ] Remove default `getMessage(ValuePhrasing phrasing)` in `DynamicValue`
- [ ] Remove `LEGACY` enum in `ValuePhrasing`
- [ ] Convert `getValueHint()` to `getHint()' [(? see discussion)](https://github.com/magefree/mage/pull/12596#discussion_r1739939902)
- [ ] Add option for "it" instead of "this" in `CountersSourceCount`
- [ ] Fix any preexisting, newly trivial oracle text errors
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.