magefree / magefree/mage

DamageMultiEffect ignores the amount provided and relies on the TargetAnyTargetAmount it needs.

Open
#12,747 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

This is very unintuitive and should be remedied, either by removing the Amount in DamageMultiEffect or firing a WrongCodeUsage exception if the sum of the multiTarget's amounts is a mismatch with the amount provided in DamageMultiEffect.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating DamageMultiEffect and the TargetAnyTargetAmount it currently relies on. Determine whether the intended resolution is to remove Amount or to raise WrongCodeUsage when the multiTarget amounts do not match it. Done means the chosen behavior is implemented and the mismatch case is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.